Skip to content

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Mar 17, 2024

Which enables ui tests to use auxiliary binaries. See the added
self-test for an example.

This is an enabler for the test in #121573.

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@oli-obk
Copy link
Contributor

oli-obk commented Mar 19, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

📌 Commit 2818540 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2024
@bjorn3
Copy link
Member

bjorn3 commented Mar 19, 2024

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Mar 19, 2024

📌 Commit 3a5eb35 has been approved by oli-obk

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122435 (Don't trigger `unused_qualifications` on global paths)
 - rust-lang#122556 (Extend format arg help for simple tuple index access expression)
 - rust-lang#122634 (compiletest: Add support for `//@ aux-bin: foo.rs`)
 - rust-lang#122677 (Fix incorrect mutable suggestion information for binding in ref pattern.)
 - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant)
 - rust-lang#122695 (Change only_local to a enum type.)
 - rust-lang#122717 (Ensure stack before parsing dot-or-call)
 - rust-lang#122719 (Ensure nested statics have a HIR node to prevent various queries from ICEing)
 - rust-lang#122720 ([doc]:fix error code example)
 - rust-lang#122724 (add test for casting pointer to union with unsized tail)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 42dec6f into rust-lang:master Mar 19, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2024
Rollup merge of rust-lang#122634 - Enselic:aux-bin, r=oli-obk

compiletest: Add support for `//@ aux-bin: foo.rs`

Which enables ui tests to use auxiliary binaries. See the added
self-test for an example.

This is an enabler for the test in rust-lang#121573.
@Enselic Enselic deleted the aux-bin branch March 20, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants